From b0a15af892a13668857cf4b365bb96ccfb3b2e0f Mon Sep 17 00:00:00 2001 From: Matthias Jaros Date: Sat, 1 Aug 2026 16:14:33 +0200 Subject: Removed parameters that are already part of the class properties --- src/main/java/com/it_jaros/jscanner/Scanner.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/it_jaros/jscanner/Scanner.java b/src/main/java/com/it_jaros/jscanner/Scanner.java index 021eb32..d0bbba7 100644 --- a/src/main/java/com/it_jaros/jscanner/Scanner.java +++ b/src/main/java/com/it_jaros/jscanner/Scanner.java @@ -216,7 +216,7 @@ public class Scanner implements AutoCloseable { if (cancelled) { return null; } - return scanHostPorts(host, scan); + return scanHostPorts(); } finally { scan.getThreadCounter().dec(); scan.getHostCounter().dec(); @@ -226,11 +226,9 @@ public class Scanner implements AutoCloseable { /** * Scans the ports of a given host * - * @param host - * @param scan * @return */ - private ScanResult scanHostPorts(final String host, final Scan scan) { + private ScanResult scanHostPorts() { if (!disableOnlineCheck && !checkHostOnline(host)) { // Unreachable host return new ScanResult( @@ -323,7 +321,7 @@ public class Scanner implements AutoCloseable { if (cancelled) { return null; } - return checkPort(host, port, scan); + return checkPort(); } finally { scan.getThreadCounter().dec(); } @@ -338,7 +336,7 @@ public class Scanner implements AutoCloseable { } } - private PortResult checkPort(String host, int port, Scan scan) throws InterruptedException { + private PortResult checkPort() throws InterruptedException { PortResult result = new PortResult(); result.setPort(port); result.setState(PortState.UNKNOWN); @@ -401,8 +399,6 @@ public class Scanner implements AutoCloseable { void add(PortResult portResult) { switch (portResult.getState()) { case OPEN -> { - // bitset is not thread-safe, so it is set - // outside the other virtual threads that update progress openPorts.set(portResult.getPort()); serviceTypes.put(portResult.getPort(), ServiceDetector.detect(portResult.getBanner())); } -- cgit v1.3.1