From 4a51139f719df8a9a0a2f5640985c4c9b3cefd56 Mon Sep 17 00:00:00 2001
From: Matthias Jaros <jarlucmat@mailbox.org>
Date: Sat, 1 Aug 2026 11:35:42 +0200
Subject: Clean Code

---
 src/main/java/com/it_jaros/jscanner/CliParser.java | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

(limited to 'src/main/java/com/it_jaros/jscanner/CliParser.java')

diff --git a/src/main/java/com/it_jaros/jscanner/CliParser.java b/src/main/java/com/it_jaros/jscanner/CliParser.java
index 81ee88d..a63b47f 100644
--- a/src/main/java/com/it_jaros/jscanner/CliParser.java
+++ b/src/main/java/com/it_jaros/jscanner/CliParser.java
@@ -41,7 +41,8 @@ public class CliParser {
                     disableOnlineCheck = true;
                     break;
                 case "--help", "-h":
-                    usageAndExit(0);
+                    printUsageHelp();
+                    System.exit(0);
                     break;
                 case "--input", "-i":
                     hostsFile = getArgument(args, ++i, currentArg);
@@ -76,7 +77,20 @@ public class CliParser {
            throw new IllegalArgumentException("No input provided. Check with --help for available options.");
         }
 
-        return new ScanOptions(hostsArgv.stream().toList(), socketLimit, delayInMillis, timeoutInMillis, maxWorkersPerHost, maxHostsLimit, ports, showFilteredPorts, disableOnlineCheck, hostsFile, quiet, bannerRecognition);
+        return new ScanOptions(
+                hostsArgv.stream().toList(),
+                hostsFile,
+                ports,
+                bannerRecognition,
+                disableOnlineCheck,
+                quiet,
+                showFilteredPorts,
+                delayInMillis,
+                maxHostsLimit,
+                maxWorkersPerHost,
+                socketLimit,
+                timeoutInMillis
+        );
     }
 
     private String getArgument(String[] args, int index, String option) {
@@ -95,7 +109,7 @@ public class CliParser {
         }
     }
 
-    public void usageAndExit(int returnCode) {
+    public void printUsageHelp() {
         StringBuilder usage = new StringBuilder();
         usage.append("""
                 Usage:
@@ -124,6 +138,5 @@ public class CliParser {
                     java -jar jscanner.jar fd00::1
                 """);
         System.err.println(usage);
-        System.exit(returnCode);
     }
 }
-- 
cgit v1.3.1