From 632041fa5acc8649e43e3ba61caed0b8e43c11b5 Mon Sep 17 00:00:00 2001 From: Matthias Jaros Date: Mon, 23 Mar 2026 12:53:34 +0100 Subject: Tiny refactoring --- src/main/java/com/it_jaros/network_scanner/Scanner.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'src/main/java') diff --git a/src/main/java/com/it_jaros/network_scanner/Scanner.java b/src/main/java/com/it_jaros/network_scanner/Scanner.java index 2153fe6..3a4b37c 100644 --- a/src/main/java/com/it_jaros/network_scanner/Scanner.java +++ b/src/main/java/com/it_jaros/network_scanner/Scanner.java @@ -90,7 +90,7 @@ public class Scanner { PortState state = getPortState(target, currentPort); if (state.equals(PortState.OPEN)) { progress.open().incrementAndGet(); - } else if (state.equals(PortState.BLOCKED)) { + } else if (state.equals(PortState.BLOCKED)) { progress.blocked().incrementAndGet(); } return new PortResult(currentPort, state); @@ -104,10 +104,13 @@ public class Scanner { List errors = new ArrayList<>(); for (Future f : futures) { try { + // bitset is not thread-safe, so it is set + // outside the other virtual threads that update progress PortResult portResult = f.get(); - switch (portResult.state()) { - case OPEN -> openPorts.set(portResult.port()); - case BLOCKED -> blockedPorts.set(portResult.port()); + if (portResult.state().equals(PortState.OPEN)) { + openPorts.set(portResult.port()); + } else if (portResult.state().equals(PortState.BLOCKED)) { + blockedPorts.set(portResult.port()); } } catch (InterruptedException e) { Thread.currentThread().interrupt(); -- cgit v1.3.1