Clean Code Use Map instead of Hashmap for immutability

2 files changed, 10 insertions, 3 deletions

diff --git a/src/main/java/com/it_jaros/jscanner/ProgressBar.java b/src/main/java/com/it_jaros/jscanner/ProgressBar.java
index bc37c12..03c8ddc 100644
--- a/src/main/java/com/it_jaros/jscanner/ProgressBar.java
+++ b/src/main/java/com/it_jaros/jscanner/ProgressBar.java
@@ -3,6 +3,7 @@ package com.it_jaros.jscanner;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
 import java.util.BitSet;
+import java.util.Map;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
@@ -81,7 +82,7 @@ public class ProgressBar {
         return ports.stream().mapToObj(String::valueOf).collect(Collectors.joining(","));
     }
 
-    private static String map(BitSet ports, java.util.HashMap<Integer, ServiceType> bannerRecognition) {
+    private static String map(BitSet ports, Map<Integer, ServiceType> bannerRecognition) {
         return ports.stream().mapToObj(port -> {
             ServiceType serviceType = bannerRecognition.getOrDefault(port, ServiceType.UNKNOWN);
 
diff --git a/src/main/java/com/it_jaros/jscanner/ScanResult.java b/src/main/java/com/it_jaros/jscanner/ScanResult.java
index 82405e7..723b7e6 100644
--- a/src/main/java/com/it_jaros/jscanner/ScanResult.java
+++ b/src/main/java/com/it_jaros/jscanner/ScanResult.java
@@ -2,6 +2,12 @@ package com.it_jaros.jscanner;
 
 import java.util.BitSet;
 import java.util.List;
+import java.util.Map;
 
-public record ScanResult(String host, BitSet openPorts, BitSet filteredPorts,
-                         java.util.HashMap<Integer, ServiceType> bannerRecognition, List<ScanFailure> errors) {}
+public record ScanResult(
+        String host,
+        BitSet openPorts,
+        BitSet filteredPorts,
+        Map<Integer, ServiceType> bannerRecognition,
+        List<ScanFailure> errors
+) {}