Improved printing of errors at result

Improved printing of success results

1 files changed, 25 insertions, 15 deletions

diff --git a/src/main/java/com/it_jaros/jscanner/ProgressBar.java b/src/main/java/com/it_jaros/jscanner/ProgressBar.java
index 2693ef1..795c9bb 100644
--- a/src/main/java/com/it_jaros/jscanner/ProgressBar.java
+++ b/src/main/java/com/it_jaros/jscanner/ProgressBar.java
@@ -46,20 +46,23 @@ public class ProgressBar {
     private void printErrors(ScanResult result) {
         if (result.errors().isEmpty()) return;
 
-        System.err.printf(
-                "error: host scan failed | host=%s | errors: %d%n",
+        StringBuilder sb = new StringBuilder();
+        sb.append(String.format(
+                "host=%s | errors: %d%n",
                 result.host(),
                 result.errors().size()
-        );
+        ));
+        String errors = result.errors().stream().map((ScanFailure error) -> String.format(
+                "\t%s: %s, %s",
+                error.port(),
+                error.exception().type(),
+                error.exception().message()
+        )).collect(Collectors.joining("\n"));
+        sb.append(errors);
+        sb.append("\n");
 
-        for (ScanFailure error : result.errors()) {
-            System.err.printf(
-                    "port: %s: %s %s%n",
-                    error.port(),
-                    error.exception().type(),
-                    error.exception().message()
-            );
-        }
+        System.err.println(sb);
+        System.err.flush();
     }
 
     private void printPortsResults(ScanResult result, boolean showFilteredPorts) {
@@ -67,14 +70,21 @@ public class ProgressBar {
             return;
         }
 
-        System.out.println(result.host());
+        StringBuilder sb = new StringBuilder();
+        sb.append(result.host());
+        sb.append("\n");
         if (!result.openPorts().isEmpty()) {
-            System.out.printf("\t (%d) open:\t%s%n", result.openPorts().cardinality(), map(result.openPorts(), result.bannerRecognition()));
+            sb.append(
+                    String.format("\t (%d) open:\t%s%n", result.openPorts().cardinality(), map(result.openPorts(), result.bannerRecognition()))
+            );
         }
         if (showFilteredPorts && !result.filteredPorts().isEmpty()) {
-            System.out.printf("\t (%d) filtered:\t%s%n", result.filteredPorts().cardinality(), map(result.filteredPorts()));
+            sb.append(
+                    String.format("\t (%d) filtered:\t%s%n", result.filteredPorts().cardinality(), map(result.filteredPorts()))
+            );
         }
-        System.out.println();
+        sb.append("\n");
+        System.out.println(sb);
         System.out.flush();
     }