commit 6dc652a21d687a89147e564ac4af8f876ca44dbb
parent 877759340ab11b407b7dc1596f749a939533b272
Author: Matthias Jaros <jaros@mailbox.org>
Date: Mon, 16 Mar 2026 16:39:43 +0100
Fixed more sonarlint findings
Diffstat:
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/main/java/com/it_jaros/networkScanner/Progress.java b/src/main/java/com/it_jaros/networkScanner/Progress.java
@@ -2,4 +2,4 @@ package com.it_jaros.networkScanner;
import java.util.concurrent.atomic.AtomicInteger;
-record Progress(String host, int total, AtomicInteger done, AtomicInteger open) {}
-\ No newline at end of file
+public record Progress(String host, int total, AtomicInteger done, AtomicInteger open) {}
+\ No newline at end of file
diff --git a/src/main/java/com/it_jaros/networkScanner/ProgressBar.java b/src/main/java/com/it_jaros/networkScanner/ProgressBar.java
@@ -9,9 +9,10 @@ import java.util.concurrent.locks.ReentrantLock;
public class ProgressBar {
- private ScheduledExecutorService ui = Executors.newSingleThreadScheduledExecutor();
+ private final ScheduledExecutorService ui = Executors.newSingleThreadScheduledExecutor();
+ private final ReentrantLock lock = new ReentrantLock();
+
private List<Progress> hosts;
- private ReentrantLock lock = new ReentrantLock();
public void start() {
this.hosts = new ArrayList<>();
@@ -68,6 +69,7 @@ public class ProgressBar {
// we need to draw one last time for the 100% to appear
drawProgress(true);
} catch (InterruptedException ignored) {
+ Thread.currentThread().interrupt();
}
}
}
diff --git a/src/main/java/com/it_jaros/networkScanner/Scanner.java b/src/main/java/com/it_jaros/networkScanner/Scanner.java
@@ -41,7 +41,7 @@ public class Scanner {
public List<ScanResult> scanTargets(List<String> targets, String ports) {
List<ScanResult> results = new ArrayList<>();
progressBar.start();
- try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();) {
+ try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor()) {
List<Future<ScanResult>> futures = new ArrayList<>();
for (String target : targets) {
futures.add(executor.submit(() -> scanTarget(target, ports)));
@@ -72,7 +72,7 @@ public class Scanner {
Progress progress = new Progress(target, portRange.getTotal(), new AtomicInteger(), new AtomicInteger());
progressBar.submit(progress);
- try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor();) {
+ try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor()) {
List<Future<Integer>> futures = new ArrayList<>();
while (portRange.hasNext()) {
maxWorkers.acquireUninterruptibly();