jscanner

commit a8dd54bc52340035a2097e19cf5d0e1f1ca1b722
parent 9eaeff3ece7059b0a6fe93ed118524ba78ddcffd
Author: Matthias Jaros <jaros@mailbox.org>
Date:   Mon, 23 Mar 2026 12:53:34 +0100

Tiny refactoring

Diffstat:
M
src/main/java/com/it_jaros/network_scanner/Scanner.java
 | 
11
+++++++----

1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/main/java/com/it_jaros/network_scanner/Scanner.java b/src/main/java/com/it_jaros/network_scanner/Scanner.java
@@ -90,7 +90,7 @@ public class Scanner {
                         PortState state = getPortState(target, currentPort);
                         if (state.equals(PortState.OPEN)) {
                             progress.open().incrementAndGet();
-                        } else if  (state.equals(PortState.BLOCKED)) {
+                        } else if (state.equals(PortState.BLOCKED)) {
                             progress.blocked().incrementAndGet();
                         }
                         return new PortResult(currentPort, state);
@@ -104,10 +104,13 @@ public class Scanner {
             List<Throwable> errors = new ArrayList<>();
             for (Future<PortResult> f : futures) {
                 try {
+                    // bitset is not thread-safe, so it is set
+                    // outside the other virtual threads that update progress
                     PortResult portResult = f.get();
-                    switch (portResult.state()) {
-                        case OPEN -> openPorts.set(portResult.port());
-                        case BLOCKED -> blockedPorts.set(portResult.port());
+                    if (portResult.state().equals(PortState.OPEN)) {
+                        openPorts.set(portResult.port());
+                    } else if (portResult.state().equals(PortState.BLOCKED)) {
+                        blockedPorts.set(portResult.port());
                     }
                 } catch (InterruptedException e) {
                     Thread.currentThread().interrupt();